Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22: Refactors Xero Client based on guzzle changes #23

Merged
merged 3 commits into from
Jun 14, 2024
Merged

22: Refactors Xero Client based on guzzle changes #23

merged 3 commits into from
Jun 14, 2024

Conversation

mradcliffe
Copy link
Owner

@mradcliffe mradcliffe commented Jun 14, 2024 •
edited
Loading

Resolves issue #22

Summary of Changes

  • Provides backwards-compatible methods from guzzle Client on XeroClientInterface and removes XeroClient from extending guzzle Client.
  • Makes incompatible change to how XeroClient is instantiated to make use of new ::createWithConfig method.
  • Deprecates InvalidOptionsException and replaces with XeroRequestException, which is injected into guzzle client via middleware.
  • Removes deprecated oauth1 functionality.

Remaining Tasks

  • None

Attribution

  • mradcliffe

@mradcliffe mradcliffe self-assigned this Jun 14, 2024
@mradcliffe mradcliffe linked an issue Jun 14, 2024 that may be closed by this pull request
Refactor due to the enshittification of guzzle #22
Closed
@mradcliffe mradcliffe merged commit 773c8dc into main Jun 14, 2024
3 checks passed
@mradcliffe mradcliffe deleted the 22-guzzle-refactor branch June 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mradcliffe mradcliffe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor due to the enshittification of guzzle
1 participant
@mradcliffe